-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add VirtualListTester #1797
Conversation
Added VirtualListTester to TesterWrappers. Extracted LitRenderer property and function methods from GridTester to HasLitRenderer mixin class for DRY reusability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some change requests.
Also, locally VirtualListTesterTest.virtualList_verifyComponentRenderer
is failing with IllegalState Span[#first-name, text='AFIOSVXE'] is not visible!
vaadin-testbench-unit-junit5/src/test/java/com/vaadin/flow/component/virtuallist/User.java
Outdated
Show resolved
Hide resolved
...h-unit-junit5/src/test/java/com/vaadin/flow/component/virtuallist/VirtualListViewTester.java
Outdated
Show resolved
Hide resolved
...h-unit-junit5/src/test/java/com/vaadin/flow/component/virtuallist/VirtualListTesterTest.java
Outdated
Show resolved
Hide resolved
...h-unit-junit5/src/test/java/com/vaadin/flow/component/virtuallist/VirtualListTesterTest.java
Outdated
Show resolved
Hide resolved
vaadin-testbench-unit-shared/src/main/java/com/vaadin/flow/component/HasLitRenderer.java
Outdated
Show resolved
Hide resolved
Hi @joelpop and all, Vaadin 24.4 RC release is scheduled on this week Wednesday. Can we make sure that this PR will be merged before that? Thanks. |
Added intentionally failing tests. Fixed some nits. Removed Instancio from project.
I will do my best. I have fixed and resolved most of the issues I knew about and that @mcollovati requested. I have just one item left. |
if the PR is ready, remember to mark it ready for review (it is still a draft at the moment.) |
Yes, it is still draft pending one outstanding implementation question. |
�
Yes, this is why I had left the PR as draft. The reason this test was failing is because |
build failed with
found one related ticket from dokka plugin, from us.. Kotlin/dokka#2509 test in PR #1799 |
validation failure has been resolved by upgrading the kotlin.version and dokka.version to 1.9.20 |
@ZheSun88 just for note, this isn't a blocker for Vaadin 24.4 release, this was planned specifically for 24.4. We can merge at any point. |
Renamed test methods to reflect how API is being tested.
… into feature/#1721-VirtualListTester
Description
Added
VirtualListTester
to enableVirtualLists
to be unit tested with TestBench.As this tester and
GridTester
both supportLitRenderer
s, the common code fromGridTester
was extracted to an interfaceHasLitRenderer
so it could be shared by both testers.Because a
VirtualList
is used to display a large list of rows, for its testing Instancio was added as a test dependency to the project to facilitate randomized generation of values.Fixes #1721
Type of change
Checklist
Additional for
Feature
type of change