Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hilla): React compatible tsconfig.json (v23.3) #889

Closed
wants to merge 1 commit into from

Conversation

platosha
Copy link
Contributor

Description

Update tsconfig.json in v23.3 template for better compatibility with React.

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@platosha platosha requested a review from Artur- November 10, 2022 10:55
@CLAassistant
Copy link

CLAassistant commented Nov 10, 2022

CLA assistant check
All committers have signed the CLA.

@Artur-
Copy link
Member

Artur- commented Nov 23, 2022

Is this still needed / up to date?

@platosha
Copy link
Contributor Author

platosha commented Dec 9, 2022

Has been updated automatically on the target branch. The PR is obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants