Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import {Router} from '@vaadin/router' does not work with Polymer CLI #207

Closed
vlukashov opened this issue Jun 29, 2018 · 0 comments
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@vlukashov
Copy link

When trying to import the Router class from the @vaadin/router package in an app bundled with polymer-cli (v 1.7.7), there is an error in the browser console and only a blank page is visible. The error is Uncaught SyntaxError: The requested module '../node_modules/@vaadin/router/dist/vaadin-router.umd.js' does not provide an export named 'Router'

Workaround:
import {Router} from '@vaadin/router/dist/vaadin-router.js';

@vlukashov vlukashov added this to the M5 milestone Jun 29, 2018
@vlukashov vlukashov added the bug Something isn't working label Jun 29, 2018
@web-padawan web-padawan self-assigned this Jun 29, 2018
vlukashov pushed a commit that referenced this issue Jun 29, 2018
vlukashov pushed a commit that referenced this issue Jan 29, 2021
- since `path-to-regexp` 3.1.0 the way of passing options into the `tokensToFunction()` function has changed (see [#191](pillarjs/path-to-regexp#191)).
- since `path-to-regexp` 4.0.0 the default exports have changed from a module object to individual functions (see [4.0.0](https://github.com/pillarjs/path-to-regexp/releases/tag/v4.0.0)).
- since `path-to-regexp` 5.0.0 the default value for the optional `encode` parameter in the `tokensToFunction()` function has changed (see [5.0.0](https://github.com/pillarjs/path-to-regexp/releases/tag/v5.0.0)).
- since `path-to-regexp` 6.0.0 the `repeat` and `modifier` properties on route regexp keys were removed (see [#207](pillarjs/path-to-regexp#207)).

The internals of the `@vaadin/router` package affected by these changes are updated so that the Vaadin Router public API remains unchanged.
vlukashov pushed a commit that referenced this issue Jan 29, 2021
- since `path-to-regexp` 3.1.0 the way of passing options into the `tokensToFunction()` function has changed (see [#191](pillarjs/path-to-regexp#191)).
- since `path-to-regexp` 4.0.0 the default exports have changed from a module object to individual functions (see [4.0.0](https://github.com/pillarjs/path-to-regexp/releases/tag/v4.0.0)).
- since `path-to-regexp` 5.0.0 the default value for the optional `encode` parameter in the `tokensToFunction()` function has changed (see [5.0.0](https://github.com/pillarjs/path-to-regexp/releases/tag/v5.0.0)).
- since `path-to-regexp` 6.0.0 the `repeat` and `modifier` properties on route regexp keys were removed (see [#207](pillarjs/path-to-regexp#207)).

The internals of the `@vaadin/router` package affected by these changes are updated so that the Vaadin Router public API remains unchanged.
haijian-vaadin pushed a commit that referenced this issue Feb 1, 2021
* fix failing tests after path-to-regexp 6.2.0 update

- since `path-to-regexp` 3.1.0 the way of passing options into the `tokensToFunction()` function has changed (see [#191](pillarjs/path-to-regexp#191)).
- since `path-to-regexp` 4.0.0 the default exports have changed from a module object to individual functions (see [4.0.0](https://github.com/pillarjs/path-to-regexp/releases/tag/v4.0.0)).
- since `path-to-regexp` 5.0.0 the default value for the optional `encode` parameter in the `tokensToFunction()` function has changed (see [5.0.0](https://github.com/pillarjs/path-to-regexp/releases/tag/v5.0.0)).
- since `path-to-regexp` 6.0.0 the `repeat` and `modifier` properties on route regexp keys were removed (see [#207](pillarjs/path-to-regexp#207)).

The internals of the `@vaadin/router` package affected by these changes are updated so that the Vaadin Router public API remains unchanged.

* chore: fix linter errors - declare `xit` global

* fix: do not re-export pathToRegexp in the ES bundle

In the ES module bundle the users may as well just import path-to-regexp themselves.

In the UMD bundle, keep things 'as-is'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants