refactor: split the package into core and pro #230
Conversation
| "main": "index.js", | ||
| "types": "index.d.ts", | ||
| "version": "24.4.0-alpha8", | ||
| "private": true, | ||
| "scripts": { |
There was a problem hiding this comment.
The build is pretty confusing:
- Most NPM scripts don't work without setting an env variable
- Most NPM scripts are generic, but some are package specific, naming is also challenging
- Scripts in
scriptsuse an env variable to determine which folder to operate in, which is kind of hidden in a utility module
Would it be feasible to duplicate the NPM scripts for the build into the respective packages and then just run the build separately inside each package folder? The modules within script could then just use the current folder as context instead of an env variable. Duplicating the NPM scripts between two packages might be a better trade-off compared to the points above.
There was a problem hiding this comment.
Good idea, this approach makes more sense than using the environment variables. Done.
packages/react-components-pro/src/renderers/useModelRenderer.ts
Outdated
Show resolved
Hide resolved
tomivirkki
dismissed stale reviews from sissbruecker and web-padawan
via
f271a6e
|
Yeah, looks like it tries to build them in parallel because |
This reverts commit f271a6e.
|
Reverted the latest change. CI/Bender can just rely on the packages being built (in the correct order) on install. Sorry about the hassle. |
Description
This PR splits the repository into two separate React wrapper packages, one for the core components and another one for the commercial ones.
Fixes #229
Type of change
Refactor