fix: allow using slotted elements in Select #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
commented
Dec 12, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
==========================================
+ Coverage 98.21% 98.28% +0.07%
==========================================
Files 25 25
Lines 168 175 +7
Branches 16 19 +3
==========================================
+ Hits 165 172 +7
Misses 1 1
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tomivirkki
reviewed
Dec 12, 2023
web-padawan
force-pushed
the
fix/select-slotted
branch
2 times, most recently
from
0040ac4 to
a4c1a6d
Compare
web-padawan
force-pushed
the
fix/select-slotted
branch
from
a4c1a6d to
7a3bce2
Compare
Lodin
requested changes
Dec 12, 2023
src/Select.tsx
Outdated
| }>; | ||
|
|
||
| function Select(props: SelectProps, ref: ForwardedRef<SelectElement>): ReactElement | null { | ||
| const children = Children.toArray(props.children as ReactNode[]); |
There was a problem hiding this comment.
I see a couple of repeating code here and below, at line 40. I guess, it also could fail if children is a function.
There was a problem hiding this comment.
Updated to not use Children.toArray and only convert props.children to array here.
src/Select.tsx
Outdated
|
|
||
| // Components with slot attribute should stay in light DOM. | ||
| const slotted = children.filter((child) => { | ||
| return typeof child === 'object' && 'props' in child && child.props.slot; |
There was a problem hiding this comment.
You can use React.isValidElement here.
web-padawan
force-pushed
the
fix/select-slotted
branch
from
53141ab to
d98590f
Compare
tomivirkki
previously approved these changes
Dec 12, 2023
Lodin
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #131
Previously,
Selectpassedprops.childrentouseSimpleOrChildrenRendereras is. This PR changes it so that we get elements withslotto be rendered in light DOM, and then evaluate remainingchildrento pass to the hook.Type of change