Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enforce using lockfile in p3-convert #158

Merged
merged 2 commits into from
Jan 20, 2022
Merged

Conversation

web-padawan
Copy link
Member

Description

Connected to https://github.com/vaadin/components-team-tasks/issues/602

  1. From now on, we assume that individual repositories keep package-lock.json in version control
  2. Added logic to handle package-lock-p3.json renaming (the file needs to be created manually)

To use this feature, the following changes are needed:

  1. Use this branch: https://github.com/vaadin/vaadin-component-dev-dependencies/tree/feat/lockfile
  2. Remove yarn install --flat from the GitHub Actions P3 workflows due to launchpad issue.

Type of change

  • Feature

This was referenced Jan 12, 2022
@web-padawan web-padawan merged commit 0542164 into master Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants