Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: restartApplication command #293

Merged
merged 2 commits into from
Jan 27, 2025
Merged

feat: restartApplication command #293

merged 2 commits into from
Jan 27, 2025

Conversation

MarcinVaadin
Copy link
Member

Fixes: #284

val selectedDescriptor = contentManager.selectedContent
if (selectedDescriptor != null) {
LOG.debug("Restarting ${project.name}")
ExecutionUtil.restart(selectedDescriptor)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this actually restart?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It restarts run profile used in current execution environment. Execution environment is found (somehow) from current data context.

Basically it is used in run toolbar while clicking run/restart button.

I might improve it by adding check if our hotswap executor has been used with this project run, currently it will restart anything what is running.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it is needed as long as Copilot uses it from a "Restart now" button or similar

@MarcinVaadin MarcinVaadin requested a review from Artur- January 27, 2025 13:24
Copy link

Artifact build on last commit: distributions.zip.
For MacOS users: there is a zip inside this zip and Finder unzips them both at once. Use unzip distributions.zip from Terminal or check solution for Archive Manager.

@MarcinVaadin MarcinVaadin enabled auto-merge (squash) January 27, 2025 13:29
@MarcinVaadin MarcinVaadin merged commit de0765f into main Jan 27, 2025
9 checks passed
@MarcinVaadin MarcinVaadin deleted the feat/restartApp branch January 27, 2025 13:33

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "restart server" command
2 participants