Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: rename Java packages #1909

Merged
merged 9 commits into from
Jan 2, 2024
Merged

feat!: rename Java packages #1909

merged 9 commits into from
Jan 2, 2024

Conversation

cromoteca
Copy link
Contributor

Part of #1904

@cromoteca cromoteca changed the title feat: rename Java packages feat!: rename Java packages Dec 20, 2023
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3ef265f) 95.24% compared to head (feab055) 95.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1909   +/-   ##
=======================================
  Coverage   95.24%   95.24%           
=======================================
  Files          52       52           
  Lines        3469     3469           
  Branches      514      514           
=======================================
  Hits         3304     3304           
  Misses        134      134           
  Partials       31       31           
Flag Coverage Δ
unittests 95.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

13 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@taefi taefi marked this pull request as ready for review January 2, 2024 12:14
@taefi taefi requested a review from platosha January 2, 2024 12:15
taefi added a commit to vaadin/sso-kit that referenced this pull request Jan 2, 2024
@platosha platosha merged commit 22f88e3 into main Jan 2, 2024
16 checks passed
@platosha platosha deleted the feat/1904/rename-packages branch January 2, 2024 15:48
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Hilla 24.4.0.alpha1 and is also targeting the upcoming stable 24.4.0 version.

taefi added a commit to vaadin/sso-kit that referenced this pull request Jan 22, 2024
* feat!: rename Hilla Java packages

follow up for vaadin/hilla#1909

* upgrade flow to 24.4-SNAPSHOT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants