Update Chrome version in Test #11613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the offsets are from the center of element instead of top-left
This reverts commit 88a8ec6.
|
|
OlliTietavainenVaadin
approved these changes
Jun 12, 2019
There was a problem hiding this comment.
Reviewed 35 of 35 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
ZheSun88
added a commit
that referenced
this pull request
Jun 12, 2019
1) recalculate the offset, as ChromeDriver starts to follow the standard; 2) update screenshots; 3) correct the `click()` call with using coordinates, related to 1) 4) `sendkey()` with using key.modifier adjustment 5) add sleep 6) workaround for mastery failures
ZheSun88
added a commit
that referenced
this pull request
Jun 12, 2019
1) recalculate the offset, as ChromeDriver starts to follow the standard; 2) update screenshots; 3) correct the `click()` call with using coordinates, related to 1) 4) `sendkey()` with using key.modifier adjustment 5) add sleep 6) workaround for mastery failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a pull request!
Please confirm that your pull request follows our guidelines found in CONTRIBUTING and that you provide enough information so that we can review your pull request.
<Description of pull request, e.g. "Fix Grid Column not sortable with backend data and sort property">
Fixes #
Check when you have completed
[ ] Valid tests for the pull request
[ ] Contributing guidelines implemented
This change is