Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent Optional capture in serializable predicate (#20360) (CP: 23.5) #20368

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

Optional is not serializable, so capturing it into a
SerializablePredicate will prevent serialization to succeed.
Copy link

Test Results

  963 files  ±0    963 suites  ±0   51m 48s ⏱️ +34s
6 310 tests +1  6 261 ✅ +1  49 💤 ±0  0 ❌ ±0 
6 575 runs  +4  6 518 ✅ +4  57 💤 ±0  0 ❌ ±0 

Results for commit 7bd24a9. ± Comparison against base commit fdb189b.

Copy link

sonarcloud bot commented Oct 29, 2024

@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot vaadin-bot merged commit 0d9fba3 into 23.5 Oct 29, 2024
24 of 26 checks passed
@vaadin-bot vaadin-bot deleted the cherry-pick-20360-to-23.5-1730198628996 branch October 29, 2024 11:05
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Vaadin 23.5.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants