Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use capture for dragLeave #20291

Merged
merged 2 commits into from
Oct 23, 2024
Merged

fix: use capture for dragLeave #20291

merged 2 commits into from
Oct 23, 2024

Conversation

tepi
Copy link
Contributor

@tepi tepi commented Oct 21, 2024

Fixes #20231

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 21, 2024 •
edited
Loading

Test Results

1 142 files  ± 0  1 142 suites  ±0   1h 25m 21s ⏱️ + 1m 37s
7 467 tests ± 0  7 417 ✅ ± 0  50 💤 ±0  0 ❌ ±0 
7 827 runs  +35  7 767 ✅ +34  60 💤 +1  0 ❌ ±0 

Results for commit 2457dbb. ± Comparison against base commit 002d5dd.

♻️ This comment has been updated with latest results.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mcollovati mcollovati self-requested a review October 23, 2024 10:02
@mcollovati mcollovati merged commit 17042ce into main Oct 23, 2024
26 checks passed
@mcollovati mcollovati deleted the fix/use-capture-for-dragleave branch October 23, 2024 10:06
vaadin-bot pushed a commit that referenced this pull request Oct 23, 2024
@tepi @vaadin-bot
fix: use capture for dragLeave (#20291)
1995e15
vaadin-bot pushed a commit that referenced this pull request Oct 23, 2024
@tepi @vaadin-bot
fix: use capture for dragLeave (#20291)
931fe78
vaadin-bot pushed a commit that referenced this pull request Oct 23, 2024
@tepi @vaadin-bot
fix: use capture for dragLeave (#20291)
c6b0bb0
vaadin-bot pushed a commit that referenced this pull request Oct 23, 2024
@tepi @vaadin-bot
fix: use capture for dragLeave (#20291)
a6d200b
vaadin-bot added a commit that referenced this pull request Oct 23, 2024
@vaadin-bot @tepi
fix: use capture for dragLeave (#20291) (#20316)
471c69d 
Co-authored-by: Teppo Kurki <[email protected]>
vaadin-bot added a commit that referenced this pull request Oct 23, 2024
@vaadin-bot @tepi
fix: use capture for dragLeave (#20291) (#20315)
f673680 
Co-authored-by: Teppo Kurki <[email protected]>
vaadin-bot added a commit that referenced this pull request Oct 23, 2024
@vaadin-bot @tepi
fix: use capture for dragLeave (#20291) (#20317)
a3000bd 
Co-authored-by: Teppo Kurki <[email protected]>
vaadin-bot added a commit that referenced this pull request Oct 23, 2024
@vaadin-bot @tepi
fix: use capture for dragLeave (#20291) (#20314)
585420e 
Co-authored-by: Teppo Kurki <[email protected]>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.6.0.alpha2 and is also targeting the upcoming stable 24.6.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollovati mcollovati mcollovati approved these changes

Assignees
No one assigned
Labels
cherry-picked-23.5 cherry-picked-24.3 cherry-picked-24.4 cherry-picked-24.5 prerelease version for Vaadin 24.6.0 Released with Vaadin 24.6.0.alpha2 target/23.5 target/24.3 target/24.4 target/24.5 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v-drag-over-target is not removed when the drop is ending in a Vaadin Grid
3 participants
@tepi @vaadin-bot @mcollovati