Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missed dependency a crypto module in Angular 6+ #3

Closed
lynx-r opened this issue Aug 5, 2019 · 2 comments
Closed

Missed dependency a crypto module in Angular 6+ #3

lynx-r opened this issue Aug 5, 2019 · 2 comments

Comments

@lynx-r
Copy link

lynx-r commented Aug 5, 2019 •
edited
Loading

  • I'm submitting a bug
    [*] bug report
    [ ] feature request
    [ ] question about the decisions made in the repository
    [ ] question about how to use this project

  • Summary

This lib doesn't work with recent Angular 6+ because of missed crypto module. You can find some discussions there angular/angular-cli#1548.

  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

If you wish I can create a PR with the fix.
@vMReal
Copy link
Owner

vMReal commented Aug 5, 2019

thanks for the bug. I am sure that the problem in using the crypto module which is native only for node js. I going to replace current module on cross platform. ASAP (I hope I can find time today)

vMReal pushed a commit that referenced this issue Aug 6, 2019
#3 crypto
77160b8 
I have replaced using native "crypto" on using cross platform "crypto-js". I have added unit tests
@vMReal vMReal mentioned this issue Aug 6, 2019
Merged
vMReal added a commit that referenced this issue Aug 6, 2019
@vMReal
Merge pull request #4 from vMReal/#3-crypto
95bd88e 
#3 crypto
@vMReal
Copy link
Owner

vMReal commented Aug 6, 2019

I have added fixes (#4) v1.0.2

@vMReal vMReal closed this as completed Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lynx-r @vMReal