fix(ci): allowlist Ascend diagnostic artifacts - #148
Merged
Conversation
ShuhaoZhangTony
marked this pull request as ready for review
July 19, 2026 17:15
Replace the raw environment artifact with a deterministic exact-key allowlist and cover credential-shaped variables with synthetic redaction tests. Signed-off-by: Shuhao Zhang (Tony) <shuhao_zhang@hust.edu.cn>
ShuhaoZhangTony
force-pushed
the
feature/security-redact-diagnostics
branch
from
July 19, 2026 17:38
a0b1d12 to
9fabfa5
Compare
Member
Author
|
@moonandlife @iliujunn @QixinZhang26 @Renty-0 — independent review is requested for this security hardening. It replaces raw diagnostic environment capture with an exact allowlist and synthetic credential-exclusion regressions. The affected benchmark workflow remains disabled until this PR receives the required approval and merges. |
Signed-off-by: Shuhao Zhang (Tony) <5267690+ShuhaoZhangTony@users.noreply.github.com>
Signed-off-by: Shuhao Zhang (Tony) <5267690+ShuhaoZhangTony@users.noreply.github.com> # Conflicts: # .github/workflows/scripts/run_e2e_inference_regression.sh # .github/workflows/scripts/run_e2e_serve_smoke.sh # tests/ci/test_ascend_benchmark_script_static.py
Signed-off-by: Shuhao Zhang (Tony) <5267690+ShuhaoZhangTony@users.noreply.github.com>
Signed-off-by: Shuhao Zhang (Tony) <shuhao_zhang@hust.edu.cn>
Signed-off-by: Shuhao Zhang (Tony) <shuhao_zhang@hust.edu.cn>
Member
Author
|
Local maintainer validation completed at exact head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VLLM_*credential variables by both key and valueRoot cause
collect_ascend_diagnosticswroteenv | sortto the benchmark result tree. The workflow uploads that tree withif: always(), while GitHub log masking does not sanitize artifact file contents.Validation
Implementation head:
9fabfa56572b74dd14abc852942296c1bb4f0d0aCurrent head:
ac878c106bcfe23807ac184ba69db0ac80316306bash -n: passedgit diff --check: passedThe current head includes the tested Ascend smoke isolation from #155; this PR remains stacked behind #155 and must pass its own exact-head smoke before merge.