Fast api unwrap #116
Merged
Fast api unwrap #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Jul 22, 2020
This commit removes the WrapperTraits specialization for FastHrtime according to recent changes in the V8 API. Refs: nodejs#33374
MayaLekova
force-pushed
the
fast-api-unwrap
branch
from
de9bbf0
to
1410b65
Compare
|
Thanks for the review! As tests are not run on this repo, the failing ones should be resolved once we update the versions in node-ci. |
victorgomes
pushed a commit
that referenced
this pull request
Aug 17, 2020
process: update v8 fast api calls usage This commit removes the WrapperTraits specialization for FastHrtime according to recent changes in the V8 API. Refs: nodejs#33374
victorgomes
pushed a commit
that referenced
this pull request
Sep 8, 2020
process: update v8 fast api calls usage This commit removes the WrapperTraits specialization for FastHrtime according to recent changes in the V8 API. Refs: nodejs#33374
victorgomes
pushed a commit
that referenced
this pull request
Oct 14, 2020
process: update v8 fast api calls usage This commit removes the WrapperTraits specialization for FastHrtime according to recent changes in the V8 API. Refs: nodejs#33374
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[upstream:v8.6.218] process: update v8 fast api calls usage
This commit removes the WrapperTraits specialization for FastHrtime
according to recent changes in the V8 API.
Refs: nodejs#33374
make -j4 test(UNIX), orvcbuild test(Windows) passes