Skip to content

Commit

Permalink
[nodejs#11570] Disable Proxy test in parallel/test-v8-serdes.js
Browse files Browse the repository at this point in the history
See: https://bugs.chromium.org/p/v8/issues/detail?id=11570

This PR disables the Proxy test in test/parallel/test-v8-serdes.js while https://chromium-review.googlesource.com/c/v8/v8/+/2739980 is being merged.

Will do another PR to re-enabled the (fixed) test once the 2739980 has landed.
  • Loading branch information
Niek authored and victorgomes committed May 22, 2023
1 parent 0e197b2 commit ec592db
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions test/parallel/test-v8-serdes.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ const hostObject = new (internalBinding('js_stream').JSStream)();
}
}

/*
// TODO(v8:11570): We disable the following test, while https://chromium-review.googlesource.com/c/v8/v8/+/2739980 is being merged
// After merging, a follow-up PR will be made to re-enable this test with changed behavior
{
const ser = new v8.DefaultSerializer();
ser._getDataCloneError = common.mustCall((message) => {
Expand All @@ -68,6 +71,7 @@ const hostObject = new (internalBinding('js_stream').JSStream)();
ser.writeValue(new Proxy({}, {}));
}, /foobar/);
}
*/

{
const ser = new v8.DefaultSerializer();
Expand Down

0 comments on commit ec592db

Please sign in to comment.