Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edges to existing graph #222

Merged
merged 9 commits into from
Mar 11, 2021
Merged

Add edges to existing graph #222

merged 9 commits into from
Mar 11, 2021

Conversation

siyuan0322
Copy link
Member

Add edges to existing graph.

@codecov-io
Copy link

codecov-io commented Mar 8, 2021

Codecov Report

Merging #222 (5166a9b) into main (a749f90) will decrease coverage by 7.79%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #222      +/-   ##
==========================================
- Coverage   75.37%   67.57%   -7.80%     
==========================================
  Files          55       55              
  Lines        4459     4463       +4     
==========================================
- Hits         3361     3016     -345     
- Misses       1098     1447     +349     
Impacted Files Coverage Δ
src/client/ds/i_object.h 90.00% <100.00%> (ø)
src/server/services/meta_service.cc 62.50% <0.00%> (-20.11%) ⬇️
src/server/server/vineyard_server.cc 58.05% <0.00%> (-17.86%) ⬇️
src/server/memory/stream_store.cc 49.56% <0.00%> (-16.23%) ⬇️
src/server/server/vineyard_server.h 85.71% <0.00%> (-14.29%) ⬇️
src/server/util/etcd_launcher.cc 65.68% <0.00%> (-13.41%) ⬇️
src/server/async/socket_server.cc 59.80% <0.00%> (-12.17%) ⬇️
src/server/util/meta_tree.cc 65.04% <0.00%> (-12.04%) ⬇️
src/server/services/etcd_meta_service.h 80.00% <0.00%> (-12.00%) ⬇️
src/server/services/meta_service.h 66.58% <0.00%> (-11.78%) ⬇️
... and 5 more

Copy link
Member

@sighingnow sighingnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Before merging, please test it against the graphscope repo to make sure everything works.

@siyuan0322
Copy link
Member Author

@sighingnow Why has the coverage dropped so much?

@sighingnow
Copy link
Member

codecov.io is a liar :)

@sighingnow sighingnow merged commit 58b3c1f into v6d-io:main Mar 11, 2021
@siyuan0322 siyuan0322 deleted the zsy/append branch March 11, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants