Skip to content

QUIC sniffer: Fix potential slice panic #3406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiaokangwang merged 5 commits into from
May 17, 2025
Merged

QUIC sniffer: Fix potential slice panic #3406

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ada3033
QUIC sniffer: Fix potential slice panic
Fangliding May 9, 2025
374176d
Fix type err
Fangliding May 9, 2025
be67b99
Update sniff.go
Fangliding May 9, 2025
d92de2f
Add test and fix more
Fangliding May 9, 2025
de94088
Refine
Fangliding May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions common/protocol/quic/sniff.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,10 @@ func SniffQUIC(b []byte) (*SniffHeader, error) {
}

extHdrLen := hdrLen + int(packetNumberLength)
// very stange packet length, maybe a fake QUIC header
Comment thread
Fangliding marked this conversation as resolved.
Outdated
if int(packetNumberLength) > int(packetLen) {
return nil, errNotQuic
}
copy(b[extHdrLen:hdrLen+4], origPNBytes[packetNumberLength:])
data := b[extHdrLen : int(packetLen)+hdrLen]

Expand Down