Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sockopt.TcpKeepAliveInterval #2149

Merged
merged 1 commit into from
Feb 19, 2023
Merged

Fix sockopt.TcpKeepAliveInterval #2149

merged 1 commit into from
Feb 19, 2023

Conversation

cubarco
Copy link
Contributor

@cubarco cubarco commented Nov 11, 2022

The Keep-Alive configs may be overridden with golang default settings when tcpKeepAliveInterval is set without tcpKeepAliveIdle.
Adopt: XTLS/Xray-core#1328

@kslr kslr requested a review from AkinoKaede December 10, 2022 09:16
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2022

Codecov Report

Base: 38.91% // Head: 38.90% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (10d3113) compared to base (9bbc3af).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2149      +/-   ##
==========================================
- Coverage   38.91%   38.90%   -0.02%     
==========================================
  Files         615      615              
  Lines       36440    36440              
==========================================
- Hits        14182    14178       -4     
- Misses      20678    20683       +5     
+ Partials     1580     1579       -1     
Impacted Files Coverage Δ
transport/internet/system_dialer.go 46.98% <0.00%> (ø)
transport/internet/system_listener.go 48.07% <0.00%> (ø)
transport/internet/udp/hub.go 73.61% <0.00%> (-4.17%) ⬇️
transport/internet/quic/hub.go 72.00% <0.00%> (-2.67%) ⬇️
proxy/vmess/outbound/outbound.go 59.05% <0.00%> (-0.79%) ⬇️
transport/internet/kcp/connection.go 72.37% <0.00%> (+0.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

The Keep-Alive configs may be overridden with golang default settings when `tcpKeepAliveInterval` is set without `tcpKeepAliveIdle`.
Adopt: XTLS/Xray-core#1328
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants