feat: Replace default Health Ping URL to HTTPS #1991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Destination URL, need 204 for success return default to chromium
4-FLOSS-Free-Libre-Open-Source-Software
changed the title
Codecov ReportBase: 38.96% // Head: 38.91% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1991 +/- ##
==========================================
- Coverage 38.96% 38.91% -0.06%
==========================================
Files 616 611 -5
Lines 36442 36367 -75
==========================================
- Hits 14199 14151 -48
+ Misses 20656 20635 -21
+ Partials 1587 1581 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
kslr
changed the title
|
I think we can use |
|
No, that https://api.v2fly.org/checkConnection.svgz URL doesn't match the requirements of returned Status code.
It is:
200 ok
instead:
204 no content.
…----------------------------------------
*From: *秋のかえで ***@***.***>
*To: *v2fly/v2ray-core ***@***.***>
*Subject: *Re: [v2fly/v2ray-core] feat: Replace default Health Ping URL to HTTPS (PR #1991)
I think we can use *https://api.v2fly.org/checkConnection.svgz*.
|
maskedeken
pushed a commit
to maskedeken/v2ray-core
that referenced
this pull request
Mar 10, 2023
Co-authored-by: ksco.he <[email protected]> Co-authored-by: 秋のかえで <[email protected]> Chore: bump google.golang.org/grpc from 1.49.0 to 1.50.0 (v2fly#2046) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> fix: socks4/4a client handshake (v2fly#1971) Feat: add transport original name to listen unix (v2fly#2048) Feat: add bind to device to Windows and Darwin (v2fly#1972) fix: Replace "math/rand" with "crypto/rand" in padding generation(v2fly#2032) Chore: github.com/lucas-clemente/quic-go from 0.29.0 to 0.29.1 (v2fly#2010) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> feat: Replace default Health Ping URL to HTTPS (v2fly#1991) Chore: update dependencies (v2fly#1995) Refactor: replace netaddr package with netipx (v2fly#1994) Fix: remove v2ctl from debian/rules (v2fly#1954) * Remove v2ctl from debian/rules It seems to be left over from v2fly#488 * Chore: use Go v1.19 to build debian package Co-authored-by: Loyalsoldier <[email protected]> Chore: bump google.golang.org/grpc from 1.48.0 to 1.49.0 (v2fly#1935) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Chore: bump github.com/google/go-cmp from 0.5.8 to 0.5.9 (v2fly#1959) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Chore: bump github.com/jhump/protoreflect from 1.12.0 to 1.13.0 (v2fly#1982) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> feat: Implement Match and MatchAny for all MatcherGroup, IndexMatcher [common/strmatcher] Implement Match and MatchAny for all MatcherGroup and IndexMatcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Destination URL, need 204 for success, return default to chromium browser URL
This is by default used by chromium based browsers and by all android >6 devices