Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky TestVMessDynamicPort (#723) #1289

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

yuhan6665
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2021

Codecov Report

Merging #1289 (1cba3d0) into master (c278db5) will increase coverage by 0.02%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1289      +/-   ##
==========================================
+ Coverage   44.64%   44.67%   +0.02%     
==========================================
  Files         485      485              
  Lines       29524    29538      +14     
==========================================
+ Hits        13182    13195      +13     
- Misses      14939    14940       +1     
  Partials     1403     1403              
Impacted Files Coverage Δ
testing/scenarios/common.go 77.69% <92.85%> (+3.55%) ⬆️
common/drain/drainer.go 65.51% <0.00%> (-6.90%) ⬇️
transport/pipe/impl.go 87.87% <0.00%> (-2.03%) ⬇️
transport/internet/kcp/connection.go 72.37% <0.00%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c278db5...1cba3d0. Read the comment docs.

@kslr
Copy link
Contributor

kslr commented Sep 25, 2021

Will anyone be using Dynamic Port? How about we delete it?

@yuhan6665
Copy link
Contributor Author

I have no idea about that. Just fixing some tests :)

Copy link
Contributor

@xiaokangwang xiaokangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this function is not being widely used right now, but until it cause any issues we can keep it.

I believe this pull request is ready to be merged.

@xiaokangwang xiaokangwang merged commit a4cd311 into v2fly:master Sep 30, 2021
xiaokangwang pushed a commit that referenced this pull request Sep 30, 2021
(cherry-picked from a4cd311, modified by committer)

See Also: #1289
@yuhan6665 yuhan6665 deleted the fix-TestVMessDynamicPort branch October 3, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants