Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disableFallbackIfMatch dns option #1270

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

nekohasekai
Copy link
Member

Allow query on DNS servers that contain a domains selector, but do not fallback to the default servers when the query fails and disableFallback disabled

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2021

Codecov Report

Merging #1270 (52caeac) into master (c58a372) will decrease coverage by 0.10%.
The diff coverage is 80.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1270      +/-   ##
==========================================
- Coverage   44.72%   44.62%   -0.11%     
==========================================
  Files         485      484       -1     
  Lines       29465    29447      -18     
==========================================
- Hits        13179    13140      -39     
- Misses      14884    14898      +14     
- Partials     1402     1409       +7     
Impacted Files Coverage Δ
app/dns/config.pb.go 22.14% <0.00%> (-0.31%) ⬇️
app/dns/dns.go 75.00% <100.00%> (+0.43%) ⬆️
infra/conf/dns.go 63.88% <100.00%> (+0.16%) ⬆️
transport/internet/udp/dispatcher.go 64.76% <0.00%> (-12.39%) ⬇️
common/buf/reader.go 82.35% <0.00%> (-5.89%) ⬇️
transport/internet/udp/hub.go 73.61% <0.00%> (-4.17%) ⬇️
proxy/freedom/freedom.go 45.00% <0.00%> (-4.00%) ⬇️
transport/internet/system_listener.go 50.00% <0.00%> (-4.00%) ⬇️
transport/internet/websocket/connection.go 16.51% <0.00%> (-3.67%) ⬇️
transport/internet/system_dialer.go 46.83% <0.00%> (-2.54%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c58a372...52caeac. Read the comment docs.

Copy link
Contributor

@xiaokangwang xiaokangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues were discovered. This pull request is ready to be merged.

@xiaokangwang xiaokangwang merged commit 00155ff into v2fly:master Sep 17, 2021
@nekohasekai nekohasekai deleted the disable-fallback-if-match branch February 19, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants