Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🍥 DNS query strategy: Add UseIPFailFast #1222

Closed
wants to merge 1 commit into from

Conversation

database64128
Copy link
Contributor

This strategy enables both IPv4 and IPv6. When either A or AAAA query fails, the lookup operation is deemed a failure.

Fixes #1209.

This strategy enables both IPv4 and IPv6. When either A or AAAA query fails, the lookup operation is deemed a failure.
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2021

Codecov Report

Merging #1222 (31b1a6c) into master (c91f98c) will decrease coverage by 0.03%.
The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1222      +/-   ##
==========================================
- Coverage   44.87%   44.84%   -0.04%     
==========================================
  Files         485      482       -3     
  Lines       29505    29413      -92     
==========================================
- Hits        13241    13190      -51     
+ Misses      14870    14830      -40     
+ Partials     1394     1393       -1     
Impacted Files Coverage Δ
app/dns/config.pb.go 22.44% <ø> (ø)
app/dns/nameserver_doh.go 67.72% <0.00%> (-1.26%) ⬇️
app/dns/nameserver_quic.go 72.60% <0.00%> (-1.36%) ⬇️
app/dns/nameserver_tcp.go 67.75% <0.00%> (-1.30%) ⬇️
app/dns/nameserver_udp.go 79.53% <0.00%> (-1.91%) ⬇️
features/dns/client.go 100.00% <ø> (ø)
infra/conf/dns.go 63.13% <0.00%> (-0.59%) ⬇️
app/dns/dns.go 71.12% <28.57%> (-3.45%) ⬇️
transport/internet/udp/dispatcher.go 64.76% <0.00%> (-12.39%) ⬇️
transport/internet/domainsocket/config.go 36.84% <0.00%> (-10.53%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c91f98c...31b1a6c. Read the comment docs.

@Mukou-Aoi
Copy link

This PR should wait for #1232 to be resolved first.

@database64128
Copy link
Contributor Author

The code changes in this PR have been relicensed under AGPLv3 and applied to a downstream fork Shadowsocks-NET/v2ray-go. Due to license requirements, these changes may not be applied to v2fly/v2ray-core.

@database64128 database64128 deleted the dns-query-strategy-use-ip-failfast branch September 3, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

内建DNS对A+AAAA结果的处理逻辑存在问题,其中一个失败不会返回错误
3 participants