-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dns cache with empty response #1183
Merged
Loyalsoldier
merged 18 commits into
v2fly:master
from
org-rurirei-folk:fix_dns_cache_emptyresponse
Aug 10, 2021
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
0b2b84c
nil check on []ip length
rurirei a860aa9
useless
rurirei e5bdf0d
typo
rurirei b051509
nil check on returned ips
rurirei a84d5e5
revert
rurirei fa74827
check found
rurirei 12f3170
fix the nil check
rurirei 13d03f5
fix the check found
rurirei a8d4289
revert
rurirei 29e35c0
use non-nil ips
rurirei c38ff1d
Update nameserver_quic.go
rurirei 409241e
Update nameserver_tcp.go
rurirei 767dfd4
Update nameserver_udp.go
rurirei d9bf267
Update nameserver_udp.go
rurirei 6cc9948
Update nameserver_tcp.go
rurirei a379dbd
Update nameserver_udp.go
rurirei 3872172
Update nameserver_udp.go
rurirei b08d67f
Refine DNS
Loyalsoldier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a bug that might caused by this changes. The program may wait until the context timeout if the records are empty, and return this error:
c.c. @Loyalsoldier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that's my mistake