Support multiple scripts modifying latent #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like PAG and SCFG are playing nicely together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PAG and the upcoming S-CFG (#35) both modify the latent. Each implementation hijacks the original combine_denoised function which is cumbersome.
This PR defines a new class
CFGCombinerwhich handles patching the combine_denoised function, and adds the guidance from each script in a deterministic way.Also handles an error in cases where get_xyz_axis_options for scripts referenced in incantation_base are not implemented.
Scripts that wish to modify the latent have their parameters added to the StableDiffusionProcessing incant_cfg_params dict.