fix: address CodeRabbit review on PR #89 - #94
Merged
Conversation
- rulesets.yml: pass workflow_dispatch inputs via env vars instead of interpolating them into the shell (template-injection / CWE-78) - rulesets.py: bind plan-id fingerprint to repo + resolved actions/IDs so a confirmation cannot be reused across repos or after create->update drift - config/governance/rulesets.json: drop hard-coded `maintainers` team from the default template; ship empty bypassActors with a substitution note - cli.py: resolve repository before client creation and pass it to require_client / require_project_client in all live handlers so GitHub App installation resolution works without PROJECT_SETUP_APP_INSTALLATION_ID - README: reconcile GitHub App auth boundary for Projects v2 and drop the obsolete "rulesets are not created" limitation - tests: cover cross-repo confirmation reuse and create-to-update drift Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Sync
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
feat/github-app-rulesets)Milestone
Summary
Applies the CodeRabbit review findings from #89 plus an extra security pass.
.github/workflows/rulesets.ymlworkflow_dispatchinputs (confirmation,mode) agora passam porenv:em vez de serem interpolados no shell.project_setup/rulesets.pyplan-idagora incluirepo+ ações resolvidas + ruleset IDs, impedindo reuso de confirmação entre repos e após drift create→update.config/governance/rulesets.jsonmaintainershard-coded do template default;bypassActors: []+ nota de substituição.project_setup/cli.pyrepo_arg(args.repo)antes de criar o client e o repassam arequire_client/require_project_client.README.mdtests/test_rulesets.pyHow to test
python3 scripts/validation/repo_quality.pypython3 -B -m unittest discover -s tests -p "test_*.py" -vEvidence
Ran 116 tests ... OKKnown risks
DoD checklist
Security pass adicional
pr-sync.yml(pull_request_target): seguro — só roda para PRs do mesmo repo, checkout apenas do base compersist-credentials: false, nunca faz checkout do PR-head.project-setup.yml: todos os inputs sãotype: boolean, sem risco de injeção.🤖 Generated with Claude Code