Skip to content

fix: harden promotion gates and embedded repository validation - #17

Merged
v-Kaefer merged 7 commits into
developfrom
fix/qa-gates-repo-quality
Aug 10, 2026
Merged

fix: harden promotion gates and embedded repository validation#17
v-Kaefer merged 7 commits into
developfrom
fix/qa-gates-repo-quality

Conversation

@v-Kaefer

Copy link
Copy Markdown
Owner

Linked Issue

Milestone

  • Release hardening / maintenance

Summary

  • Harden the Q.A and main source-branch gates by running metadata-only validation from pull_request_target.
  • Replace path-based source repository detection with a dedicated .project-setup-source marker that is never installed into target repositories.
  • Allow embedded targets to preserve their own Makefile/workflow caller files while still validating managed scripts and installer coverage.
  • Add regression tests for target-owned tests/test_project_setup.py and preserved target Makefiles.

How to test

  • Test type: automated / E2E
  • Steps: run make check; run the Q.A repository-mode E2E tests; verify both promotion workflows use pull_request_target and contain no checkout step.

Evidence

  • Diff limited to the three actionable CodeRabbit findings and regression tests
  • Repository CI green
  • CodeRabbit findings resolved/re-reviewed

Known risks

  • pull_request_target is intentionally used only for metadata-only gates; these workflows must remain free of checkout or execution of pull-request code.
  • .project-setup-source is source-only and must not be added to installer template manifests.

DoD checklist

  • Scope implemented as defined
  • Regression tests added
  • Tests executed and documented by CI
  • No known critical breakage introduced

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@v-Kaefer, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 12 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1bd64980-8a88-4aa5-a0c5-3e5f6c7e01d8

📥 Commits

Reviewing files that changed from the base of the PR and between 688bf63 and 38c20ad.

📒 Files selected for processing (7)
  • .github/workflows/main-source-branch.yml
  • .github/workflows/qa-source-branch.yml
  • .project-setup-source
  • Makefile
  • scripts/validation/repo_quality.py
  • tests/qa/test_repository_mode_e2e.py
  • tests/test_qa_workflows.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@v-Kaefer
v-Kaefer merged commit e403d3a into develop Aug 10, 2026
4 checks passed
@v-Kaefer
v-Kaefer deleted the fix/qa-gates-repo-quality branch August 10, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant