Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH CI problems related to volumes #9700

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cbosdo
Copy link
Contributor

@cbosdo cbosdo commented Jan 29, 2025

What does this PR change?

Add missing /var/spacewalk/* packages to uyuni-base.spec

The /var/spacewalk/{systems,packages} folders where created by spacewalk-setup before the recent refactoring. Now that they have been removed from the setup scriptm they need to be part of the uyuni-base-server package like their parent.

Since the GH PR acceptance tests are only using a released image and deploy changes to it, the spec file changes won't be there. They need to be duplicated by the CI setup, hence the create of a setup_missing_folders.sh script.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • Cucumber tests were fixed

  • DONE

Links

Issue(s): #
Port(s): # add downstream PR(s), if any

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

…is fixed on GH validation"

This reverts commit d9c5261.
@cbosdo cbosdo requested a review from a team as a code owner January 29, 2025 15:48
@cbosdo cbosdo marked this pull request as draft January 29, 2025 15:48
Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9700/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9700/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

The /var/spacewalk/{systems,packages} folders where created by
spacewalk-setup before the recent refactoring. Now that they have been
removed from the setup scriptm they need to be part of the
uyuni-base-server package like their parent.

Since the GH PR acceptance tests are only using a released image and
deploy changes to it, the spec file changes won't be there. They need to
be duplicated by the CI setup, hence the create of a
setup_missing_folders.sh script.
@cbosdo cbosdo marked this pull request as ready for review January 30, 2025 12:49
Copy link
Member

@srbarrios srbarrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No clue about spacewalk-setup changes, but the rest lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants