-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GH CI problems related to volumes #9700
base: master
Are you sure you want to change the base?
Conversation
…is fixed on GH validation" This reverts commit d9c5261.
👋 Hello! Thanks for contributing to our project. If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
The /var/spacewalk/{systems,packages} folders where created by spacewalk-setup before the recent refactoring. Now that they have been removed from the setup scriptm they need to be part of the uyuni-base-server package like their parent. Since the GH PR acceptance tests are only using a released image and deploy changes to it, the spec file changes won't be there. They need to be duplicated by the CI setup, hence the create of a setup_missing_folders.sh script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No clue about spacewalk-setup changes, but the rest lgtm
What does this PR change?
Add missing /var/spacewalk/* packages to uyuni-base.spec
The /var/spacewalk/{systems,packages} folders where created by spacewalk-setup before the recent refactoring. Now that they have been removed from the setup scriptm they need to be part of the uyuni-base-server package like their parent.
Since the GH PR acceptance tests are only using a released image and deploy changes to it, the spec file changes won't be there. They need to be duplicated by the CI setup, hence the create of a setup_missing_folders.sh script.
GUI diff
No difference.
Documentation
No documentation needed: only internal and user invisible changes
DONE
Test coverage
Cucumber tests were fixed
DONE
Links
Issue(s): #
Port(s): # add downstream PR(s), if any
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!