Detect binutils version to disable waitpkg/tpause intrinsic if GNU assembler is too old. #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sembler is too old. Signed-off-by: Martijn Courteaux <[email protected]>
|
@aepanchi Please look at the comments wording. |
|
@omalyshe I changed the code to be matching better the comments and be less confusing. |
aepanchi
reviewed
Apr 18, 2024
Co-authored-by: Alexandra <[email protected]>
isaevil
reviewed
Apr 30, 2024
|
I updated the PR with your feedback, @isaevil. |
isaevil
reviewed
May 3, 2024
14 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #859 #1023.
Type of change
Tests
Documentation
Breaks backward compatibility
Notify the following users
@mcmillan03 @kboyarinov @markdewing @phprus @isaevil @HorizonLiang @bsergean @pavelkumbrasev
Other information