Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNG] Add geometric distribution to Device API #622

Merged
merged 10 commits into from
Dec 23, 2024
Merged

[RNG] Add geometric distribution to Device API #622

merged 10 commits into from
Dec 23, 2024

Conversation

iMartyan
Copy link
Contributor

@iMartyan iMartyan commented Dec 13, 2024 •
edited
Loading

Description

Added geometric distribution to RNG Device API. Distribution is based on the ICDF method
Added:

  • Feature
  • Unit tests

Checklist

New features

  • Have you provided motivation for adding a new feature? - Spec PR #604
  • Have you added relevant tests? - new tests added for geometric distribution

@iMartyan iMartyan marked this pull request as ready for review December 17, 2024 15:49
@iMartyan iMartyan requested a review from a team as a code owner December 17, 2024 15:49
andreyfe1
andreyfe1 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@andreyfe1 andreyfe1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall

include/oneapi/math/rng/device/detail/geometric_impl.hpp Show resolved Hide resolved
include/oneapi/math/rng/device/detail/geometric_impl.hpp Outdated Show resolved Hide resolved
aelizaro
aelizaro approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@aelizaro aelizaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@iMartyan iMartyan merged commit be58ee0 into uxlfoundation:develop Dec 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelizaro aelizaro aelizaro approved these changes

@andreyfe1 andreyfe1 andreyfe1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iMartyan @andreyfe1 @aelizaro