oneMKL: replace unsupported sycl::vector_class with std:vector in USM API #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelizaro
approved these changes
Oct 12, 2021
| @@ -139,7 +139,7 @@ gemm (USM version) | |||
| const fp beta, | |||
| const fp *C, | |||
| const std::int64_t ldc, | |||
| const sycl::vector_class<sycl::event> &dependencies = {}); | |||
| const std::vector<sycl::event> &dependencies = {}); | |||
There was a problem hiding this comment.
it looks like for sparse blas, the &dependencies was previously aligned with other arg names, I don't see this pattern for blas, lapack, dft, rng, stats or vm. Do you think we can got through these few and realign the args? not super important, but could be good.
| @@ -154,7 +154,7 @@ compute_backward (USM version) | |||
| template <typename descriptor_type, typename data_type> | |||
| sycl::event compute_backward( descriptor_type &desc, | |||
| data_type *inout, | |||
| const cl::sycl::vector_class<cl::sycl::event> &dependencies = {}); | |||
| const std::vector<cl::sycl::event> &dependencies = {}); | |||
There was a problem hiding this comment.
actually looks like dft also had args tab aligned. can we realign &dependencies with other args ?
spencerpatty
approved these changes
Oct 13, 2021
There was a problem hiding this comment.
Hi @mkrainiuk this PR looks good. I can confirm you caught all the references to sycl::vector_class. Short of a few stylistic changes with whitespace alignment, I approve this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class
sycl::vector_classhas been removed from SYCL 2020 and the standard classstd::vectorshould be used instead (SYCL 2020 spec p491).This PR updates oneMKL USM API to align with SYCL 2020.