[oneTBB] Heterogeneous overloads for concurrent_hash_map #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ivankochin, @alexey-katranov, @alexandraepan, could you please review? |
aepanchi
reviewed
Aug 23, 2021
source/elements/oneTBB/source/containers/concurrent_hash_map_cls/iterators.rst
Outdated
Show resolved
Hide resolved
source/elements/oneTBB/source/containers/concurrent_hash_map_cls/iterators.rst
Outdated
Show resolved
Hide resolved
source/elements/oneTBB/source/containers/concurrent_hash_map_cls/iterators.rst
Outdated
Show resolved
Hide resolved
source/elements/oneTBB/source/containers/concurrent_hash_map_cls/lookup.rst
Outdated
Show resolved
Hide resolved
source/elements/oneTBB/source/containers/concurrent_hash_map_cls/lookup.rst
Outdated
Show resolved
Hide resolved
source/elements/oneTBB/source/containers/concurrent_hash_map_cls/modifiers.rst
Outdated
Show resolved
Hide resolved
source/elements/oneTBB/source/containers/concurrent_hash_map_cls/modifiers.rst
Outdated
Show resolved
Hide resolved
source/elements/oneTBB/source/containers/concurrent_hash_map_cls/iterators.rst
Outdated
Show resolved
Hide resolved
source/elements/oneTBB/source/containers/concurrent_hash_map_cls/lookup.rst
Outdated
Show resolved
Hide resolved
source/elements/oneTBB/source/containers/concurrent_hash_map_cls/modifiers.rst
Outdated
Show resolved
Hide resolved
ivankochin
reviewed
Aug 31, 2021
source/elements/oneTBB/source/containers/concurrent_hash_map_cls/iterators.rst
Outdated
Show resolved
Hide resolved
| @@ -52,3 +52,21 @@ equal_range | |||
| a pair of iterators ``{f, l}``, where ``f`` is an iterator to this element, | |||
There was a problem hiding this comment.
Suggested change
| a pair of iterators ``{f, l}``, where ``f`` is an iterator to this element, | |
| returns a pair of iterators ``{f, l}``, where ``f`` is an iterator to this element, |
There was a problem hiding this comment.
I have rephrased this section in the other manner.
|
@kboyarinov if file was updated, please add 2021 to the license. For example, .. SPDX-FileCopyrightText: 2019-2021 Intel Corporation. If file was just created, use .. SPDX-FileCopyrightText: 2021 Intel Corporation |
aepanchi
reviewed
Sep 4, 2021
source/elements/oneTBB/source/containers/concurrent_hash_map_cls/lookup.rst
Outdated
Show resolved
Hide resolved
source/elements/oneTBB/source/containers/concurrent_hash_map_cls/iterators.rst
Outdated
Show resolved
Hide resolved
source/elements/oneTBB/source/containers/concurrent_hash_map_cls/iterators.rst
Outdated
Show resolved
Hide resolved
source/elements/oneTBB/source/containers/concurrent_hash_map_cls/modifiers.rst
Outdated
Show resolved
Hide resolved
source/elements/oneTBB/source/containers/concurrent_hash_map_cls/modifiers.rst
Outdated
Show resolved
Hide resolved
source/elements/oneTBB/source/containers/concurrent_hash_map_cls/modifiers.rst
Outdated
Show resolved
Hide resolved
source/elements/oneTBB/source/containers/concurrent_hash_map_cls/modifiers.rst
Outdated
Show resolved
Hide resolved
| template <typename K> | ||
| bool erase( const K& key ); | ||
|
|
||
| If an element with the key that compares equivalent to the value ``key`` exists, removes it from the container. |
source/elements/oneTBB/source/containers/concurrent_hash_map_cls/modifiers.rst
Outdated
Show resolved
Hide resolved
source/elements/oneTBB/source/containers/concurrent_hash_map_cls/modifiers.rst
Outdated
Show resolved
Hide resolved
ivankochin
approved these changes
Sep 20, 2021
source/elements/oneTBB/source/containers/concurrent_hash_map_cls.rst
Outdated
Show resolved
Hide resolved
| // Parallel iteration | ||
| range_type range( std::size_t grainsize = 1 ); | ||
| const_range_type range( std::size_t grainsize = 1 ) const; | ||
| }; // class concurrent_hash_map | ||
|
|
There was a problem hiding this comment.
This line removing is inconsistent with the namespace opening.
…ls.rst Co-authored-by: Ivan Kochin <[email protected]>
ivankochin
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding description for heterogeneous overloads for concurrent_hash_map member functions (find, count, erase, insert, equal_range).
Signed-off-by: kboyarinov [email protected]