Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle annotations and locations better #42

Merged
merged 2 commits into from
Feb 4, 2021
Merged

Handle annotations and locations better #42

merged 2 commits into from
Feb 4, 2021

Conversation

uabboli
Copy link
Contributor

@uabboli uabboli commented Jan 13, 2021

This PR is one of several affecting repositories on Github. It
aims at fixing bad use of annotations (see erl_anno(3)). The
following remarks are common to all PR:s.

Typically the second element of abstract code tuples is assumed
to be an integer, which is no longer always true. For instance,
the parse transform implementing QLC tables (see qlc(3)) returns
code where some annotations are marked as `generated'. Such an
annotation is a list, not an integer (it used to be a negative
integer).

As of Erlang/OTP 24.0, the location can be a tuple {Line, Column},
which is another reason to handle annotations properly.

This PR is one of several affecting repositories on Github. It
aims at fixing bad use of annotations (see erl_anno(3)). The
following remarks are common to all PR:s.

Typically the second element of abstract code tuples is assumed
to be an integer, which is no longer always true. For instance,
the parse transform implementing QLC tables (see qlc(3)) returns
code where some annotations are marked as `generated'. Such an
annotation is a list, not an integer (it used to be a negative
integer).

As of Erlang/OTP 24.0, the location can be a tuple {Line, Column},
which is another reason to handle annotations properly.
@paulo-ferraz-oliveira
Copy link

Once this is accepted could parse_trans be tagged? I'm compiling stuff in preparation for OTP 24 and parse_trans is base for many. Thanks.

@uwiger uwiger merged commit 4376d81 into uwiger:master Feb 4, 2021
@paulo-ferraz-oliveira
Copy link

paulo-ferraz-oliveira commented Feb 7, 2021

Hm... this only improves the parse_trans code, right @uabboli? I still get issues when e.g. parse_trans is used inside jobs.

Edit: I created a pull request to keep previous behaviour from breaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants