feat: update IC filter logic for duration_constraint. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosgjs
approved these changes
Jul 22, 2024
| """ | ||
| Returns the lat and long of the cluster to which the trace(row) belongs. | ||
| """ | ||
| if dur_constr: | ||
| lat_long = (row[STAY_LAT], row[STAY_LONG]) | ||
| unc = row[STAY_UNC] |
There was a problem hiding this comment.
Could this be simplified by adding STAY_UNC column with default value -1 when the file is initially loaded if the column is not present? I'm not sure if such columns are stored in a memory efficient way by pandas but probably worth trying. It would remove the need to pass around the df_columns and to have these special cases.
There was a problem hiding this comment.
Yes, was thinking the same. Will have to crosscheck for accuracy and timing as well.
Meanwhile, created an issue to explore this separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#46 #67
Update the incremental clustering algorithm to use duration_constraint-based filtering for post-stay determination.
An additional description has been highlighted in the linked issue.
Working Solution for the cases when the 'unc' column is missing/optional in the input.