Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #94

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Update README.md #94

merged 1 commit into from
Dec 2, 2020

Conversation

e-wai
Copy link
Collaborator

@e-wai e-wai commented Dec 2, 2020

Make sure everyone knows to adjust the pytest command because API key isn't publicly available

Make sure everyone knows to adjust the `pytest` command because API key isn't publicly available
Copy link
Member

@ufshk ufshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK but there's one problem.

The tests never needed the API key originally :D

That is a good thing right?

(I just mocked responses.)

@e-wai
Copy link
Collaborator Author

e-wai commented Dec 2, 2020

Uhh am I just reading these wrong ->

def test_elevation_getter_good_inputs():
waypoints = [{"45": "-74"}, {"46": "-75"}]
viawaypoints = [[{"45.5": "-74.5"}]]
elev = ElevationDataRetrieval(waypoints, viawaypoints)
response = elev.get_elevation_data()
assert(response.status_code == 200)
def test_elevation_getter_bad_inputs():
waypoints = [{}, {}]
viawaypoints = [[{}]]
elev = ElevationDataRetrieval(waypoints, viawaypoints)
response = elev.get_elevation_data()
assert(response.status_code == 500)

@ufshk
Copy link
Member

ufshk commented Dec 2, 2020

ok so not all of them used mock responses, but I intend that they do now, since we can't use the key

@mdshiozaki mdshiozaki merged commit 091a2e5 into master Dec 2, 2020
@e-wai e-wai deleted the readme-pytest-ignore branch December 4, 2020 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants