[STRAT-114] Route Model Refactor- Elevations Finalized #93
Conversation
| for key in pair.keys(): | ||
| # Step 2: Multiply each value by 100000 and round each result to the nearest int | ||
| new_lat = int(round(float(key) * 100000)) | ||
| new_long = int(round(float(pair[key]) * 100000)) |
There was a problem hiding this comment.
Could swap pair[key] with value if you change line 34 to for key, value in pair.items()
| new_long = int(round(float(pair[key]) * 100000)) | ||
|
|
||
| # Step 3: Calculate the difference between every pair of values | ||
| dx = (new_lat - lat) |
There was a problem hiding this comment.
Sorry this is small, but don't think the brackets do anything for readability
| # each remainder, stop when the quotient reaches zero | ||
| rem = [] | ||
| while index > 0: | ||
| rem.append(int(index % 32)) |
There was a problem hiding this comment.
if you start with an int, think the int cast call is redundant
| rem = [] | ||
| while index > 0: | ||
| rem.append(int(index % 32)) | ||
| index = int(index / 32) |
There was a problem hiding this comment.
Can replace with index // 32
| sys.exit() | ||
| # append specified elevation URL details | ||
| url = BASE_URL + 'Elevation/Polyline?' | ||
| sample = str(sample_val) |
There was a problem hiding this comment.
don't think you need the string cast; can just put it directly into format?
| # loop through coordinates and write coordinates into DataFrame | ||
| counter = 0 | ||
| for index, pair in enumerate(coordinates): | ||
| for key in pair.keys(): |
Yes, yes you can. |
krishna-kalavadia
changed the title
Thanks for taking the time to review this! |
Elevations file completed. Also regenerated the Heartland Elevations because the last one had errors so that is also included in this PR, so only two files.