Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add files from Micah Black on SoC refactor #86

Merged
merged 1 commit into from
Nov 7, 2020
Merged

Add files from Micah Black on SoC refactor #86

merged 1 commit into from
Nov 7, 2020

Conversation

e-wai
Copy link
Collaborator

@e-wai e-wai commented Nov 6, 2020 •
edited
Loading

  • Moves current soc files into soc_deprecated folder in preparation for refactor.
  • Micah Black's work in trying to implement the corrections for SOC-OCV discrepancies based on testing is added into SOC folder.
  • Any file paths referring to old soc files are changes to soc.soc_deprecated
  • Haven't looked through Micah's code yet FYI

(Yes, I will need to adjust the testing)

mdshiozaki
mdshiozaki approved these changes Nov 7, 2020
View reviewed changes
Copy link
Collaborator

@mdshiozaki mdshiozaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix is coming so approving

@mdshiozaki mdshiozaki merged commit 0d23e27 into master Nov 7, 2020
@e-wai e-wai deleted the soc-refactor branch March 24, 2021 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdshiozaki mdshiozaki mdshiozaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e-wai @mdshiozaki