who: honor locale settings #8535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuankunzhang
force-pushed
the
who-honor-locale
branch
4 times, most recently
from
bb6f59a to
a5e942c
Compare
|
GNU testsuite comparison: |
cakebaker
reviewed
Sep 1, 2025
yuankunzhang
force-pushed
the
who-honor-locale
branch
from
a5e942c to
4b36064
Compare
cakebaker
reviewed
Sep 1, 2025
Comment on lines
+171
to
+178
| let time_format: Vec<time::format_description::FormatItem> = if lc_time == "C" { | ||
| // "%b %e %H:%M" | ||
| time::format_description::parse("[month repr:short] [day padding:space] [hour]:[minute]") | ||
| .unwrap(); | ||
| ut.login_time().format(&time_format).unwrap() // LC_ALL=C | ||
| .unwrap() | ||
| } else { | ||
| // "%Y-%m-%d %H:%M" | ||
| time::format_description::parse("[year]-[month]-[day] [hour]:[minute]").unwrap() | ||
| }; |
Contributor
There was a problem hiding this comment.
It's probably outside the scope of this PR: GNU who also uses the C format for invalid/non-installed locales:
$ LC_ALL=invalid who -b
system boot Sep 1 13:24
$ LC_ALL=fr_FR.UTF-8 who -b
system boot Sep 1 13:24
|
GNU testsuite comparison: |
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8508.