Skip to content

Conversation

@sylvestre
Copy link
Contributor

No description provided.

@sylvestre sylvestre force-pushed the clap-loca-improv branch 2 times, most recently from 62bf961 to c287842 Compare August 24, 2025 19:50
@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre marked this pull request as ready for review August 24, 2025 20:39
@sylvestre sylvestre requested a review from Copilot August 24, 2025 20:39
@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@sylvestre sylvestre requested a review from cakebaker August 25, 2025 07:22
Copy link
Contributor

@cakebaker cakebaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre force-pushed the clap-loca-improv branch 3 times, most recently from 7cfeadf to 2e98e80 Compare August 25, 2025 21:30
@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/du/threshold. tests/du/threshold is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre requested a review from cakebaker August 25, 2025 22:03
Copy link
Contributor

@cakebaker cakebaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that you removed all crate::locale::setup_localization(util_name); calls in the non-test code. Is that correct?

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/du/threshold. tests/du/threshold is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@sylvestre
Copy link
Contributor Author

Yes, it seems unnecessary

@cakebaker
Copy link
Contributor

cakebaker commented Aug 26, 2025

I don't know if you have seen that tests/du/threshold fails. For some reason an error message of du changes. On main:

$ cargo run -q du --threshold
error: a value is required for '--threshold <SIZE>' but none was supplied

For more information, try '--help'.

And on the branch with the changes from this PR:

$ cargo run -q du --threshold
error: a value is required for '--threshold <SIZE>' but none was supplied

  [possible values: ]

For more information, try '--help'.

@sylvestre
Copy link
Contributor Author

du fixed with a test to make sure we identify the issue more quickly :)

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@cakebaker cakebaker merged commit 0b2d52d into uutils:main Aug 28, 2025
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants