-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
clap localization improvements #8520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
62bf961 to
c287842
Compare
|
GNU testsuite comparison: |
c287842 to
704a04c
Compare
|
GNU testsuite comparison: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
cakebaker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done :)
704a04c to
5844d28
Compare
|
GNU testsuite comparison: |
7cfeadf to
2e98e80
Compare
|
GNU testsuite comparison: |
cakebaker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that you removed all crate::locale::setup_localization(util_name); calls in the non-test code. Is that correct?
|
GNU testsuite comparison: |
|
Yes, it seems unnecessary |
|
I don't know if you have seen that And on the branch with the changes from this PR: |
0267033 to
2d0985d
Compare
|
du fixed with a test to make sure we identify the issue more quickly :) |
|
GNU testsuite comparison: |
No description provided.