od: Switch f16 print to width=15/16, precision=8 #8433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drinkcat
force-pushed
the
od-f16-f32-width
branch
from
ec3e3c8 to
a17e606
Compare
|
GNU testsuite comparison: |
While I think precision=4 is enough to print f16 unambiguously, being consistent with GNU implementation does not hurt. Also, change width to 16 for f32 as well. Fixes uutils#8370.
drinkcat
force-pushed
the
od-f16-f32-width
branch
from
a17e606 to
991ba21
Compare
|
GNU testsuite comparison: |
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I think precision=4 is enough to print f16 unambiguously, being consistent with GNU implementation does not hurt.
Also, change width to 16 for f32 as well.
Fixes #8370.