Skip to content

Conversation

@drinkcat
Copy link
Collaborator

@drinkcat drinkcat commented Aug 5, 2025

Looks like there is a CI coverage gap...

cargo +stable clippy --workspace --all-targets --all-features -- -D warnings

error: variables can be used directly in the `format!` string
   --> src/uucore/src/lib/mods/locale.rs:750:17
    |
750 |                 eprintln!("Init localization failed: {}", e);
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
    = note: `-D clippy::uninlined-format-args` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
    |
750 -                 eprintln!("Init localization failed: {}", e);
750 +                 eprintln!("Init localization failed: {e}");
    |

error: could not compile `uucore` (lib test) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

@github-actions
Copy link

github-actions bot commented Aug 5, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre merged commit 1d20d71 into uutils:main Aug 5, 2025
89 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants