Skip to content

Conversation

@RenjiSann
Copy link
Collaborator

@RenjiSann RenjiSann commented Jul 24, 2025

Fixes

This MR changes the type used to represent content from &str to &[u8], allowing for non-UTF-8 text to be processed.
Additionally, it makes behavior changes to 100% match GNU LC_ALL=C behavior, preparing the ground for latter localization support.

Notable changes:

  • Multiple fixture files: Blessed the debug output that was incorrect for the LC_ALL=C locale.
  • test_util_name.rs: Ignore 2 tests that assumed sort coudn't process invalid UTF-8 to check the binary name.
  • uucore::version_cmp: API change to handle &[u8] instead of &str.
  • ls.rs: Consequences of the changes in version_cmp.

@RenjiSann RenjiSann marked this pull request as draft July 24, 2025 12:45
@RenjiSann RenjiSann force-pushed the improve-sort branch 4 times, most recently from 05c4955 to 4133634 Compare July 24, 2025 13:35
@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/df/problematic-chars is no longer failing!

@RenjiSann RenjiSann force-pushed the improve-sort branch 4 times, most recently from a13fae4 to d1727e9 Compare July 24, 2025 15:01
@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@RenjiSann RenjiSann marked this pull request as ready for review July 24, 2025 16:01
@RenjiSann RenjiSann requested review from cakebaker and sylvestre and removed request for sylvestre July 24, 2025 16:01
@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@cakebaker cakebaker merged commit 8bbce0d into uutils:main Jul 25, 2025
76 checks passed
@cakebaker
Copy link
Contributor

Good work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants