cp: Try to change gid only if changing uid+gid fails #8385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, if a file with ownership `root:wheel` is copied with `-p`, we expect the copy to have ownership `$USER:wheel` (assuming `$USER` is part of `wheel` group) It's not possible to add a unit test for this, as it requires a file with non-$USER ownership, which can only be created by root (or another user).
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8383, and would fix
tests/cp/preserve-gidif we didn't hit #8382 (I added+rxpermission to my home directory to work around the issue).For example, if a file with ownership
root:wheelis copied with-p, we expect the copy to have ownership$USER:wheel(assuming
$USERis part ofwheelgroup)It's not possible to add a unit test for this, as it requires a
file with non-$USER ownership, which can only be created by root
(or another user).