tail: fix tailing /dev/zero #8314
Conversation
|
GNU testsuite comparison: |
src/uu/tail/src/tail.rs
Outdated
| use std::collections::HashMap; | ||
| use std::fs::File; | ||
| use std::io::{self, BufReader, BufWriter, ErrorKind, Read, Seek, SeekFrom, Write, stdin, stdout}; | ||
| use std::os::unix::fs::MetadataExt; |
There was a problem hiding this comment.
You have to use a #[cfg] attribute as this line doesn't work on Windows.
| use std::os::unix::fs::MetadataExt; | |
| #[cfg(unix)] | |
| use std::os::unix::fs::MetadataExt; |
|
Thank you for all of the feedback, I believe I have addressed them all. The file size versus blocksize check is now very similar to what is in head.rs, which seems to be more fleshed out. It will work on Windows now. The renaming of |
|
GNU testsuite comparison: |
I think there was a problem with your force push because there is no change (cf the diff) |
|
You're right. I've pushed again. |
This fixes a bug where tail would run forever when tailing /dev/zero. This behavior matches GNU tail.
|
Ah I didn't realize that tail had its own crate and Cargo.toml. I've updated the uucore dependency to include the "fs" feature. |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Kudos, and thanks for your PR! |
4 participants
This fixes a bug where tail would run forever when tailing /dev/zero. This behavior matches GNU tail.