stty: special settings
#8309
Merged
stty: special settings
#8309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
willshuttleworth
force-pushed
the
stty-special-settings
branch
from
3584501 to
ec40c3d
Compare
|
GNU testsuite comparison: |
willshuttleworth
force-pushed
the
stty-special-settings
branch
2 times, most recently
from
20f9e88 to
e70cbce
Compare
|
GNU testsuite comparison: |
cakebaker
reviewed
Jul 5, 2025
src/uu/stty/src/stty.rs
Outdated
| } else if *arg == "line" { | ||
| match args_iter.next() { | ||
| Some(line) => { | ||
| if let Ok(n) = line.parse::<u32>() { |
Contributor
There was a problem hiding this comment.
What's the reason for parsing u32 instead of u8? It would allow you to get rid of the size check and the casting.
cakebaker
reviewed
Jul 5, 2025
willshuttleworth
force-pushed
the
stty-special-settings
branch
from
e70cbce to
9e029f5
Compare
|
GNU testsuite comparison: |
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3859, specifically the
drain,line,min, andtimesettings