Skip to content

touch: fix f flag #8274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cakebaker merged 8 commits into from
Jun 29, 2025
Merged

touch: fix f flag #8274

cakebaker merged 8 commits into from
Jun 29, 2025

Conversation

@VenetiaFurtado
Copy link
Contributor

@VenetiaFurtado VenetiaFurtado commented Jun 26, 2025

Fixes #8270
Add support for the -f (force) flag in the touch utility.

@sylvestre
Copy link
Contributor

sylvestre commented Jun 26, 2025

please add a test to make sure we don't regress

sylvestre
sylvestre reviewed Jun 26, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jun 26, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@VenetiaFurtado @sylvestre
Update src/uu/touch/src/touch.rs
61db5f2 
Co-authored-by: Sylvestre Ledru <[email protected]>
@VenetiaFurtado
Copy link
Contributor Author

VenetiaFurtado commented Jun 26, 2025

please add a test to make sure we don't regress

I'm working on it..

@VenetiaFurtado
Copy link
Contributor Author

VenetiaFurtado commented Jun 26, 2025

Just confirming, GNU touch utility explicitly documents its -f flag in --help, is it intended to be hidden in this implementation?

@satmandu
Copy link

satmandu commented Jun 27, 2025

Also fyi: https://www.gnu.org/software/coreutils/manual/html_node/touch-invocation.html

‘-f’
Ignored; for compatibility with BSD versions of touch.

@github-actions
Copy link

github-actions bot commented Jun 27, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Jun 28, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

cakebaker
cakebaker reviewed Jun 28, 2025
View reviewed changes
cakebaker
cakebaker reviewed Jun 28, 2025
View reviewed changes
VenetiaFurtado and others added 2 commits June 28, 2025 10:36
@VenetiaFurtado @cakebaker
Update src/uu/touch/src/touch.rs
509dfc7 
Co-authored-by: Daniel Hofstetter <[email protected]>
@VenetiaFurtado @cakebaker
Update tests/by-util/test_touch.rs
5362dba 
Co-authored-by: Daniel Hofstetter <[email protected]>
@github-actions
Copy link

github-actions bot commented Jun 28, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Jun 29, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

sylvestre
sylvestre reviewed Jun 29, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jun 29, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@cakebaker cakebaker merged commit c64adee into uutils:main Jun 29, 2025
76 checks passed
@cakebaker
Copy link
Contributor

cakebaker commented Jun 29, 2025

Thanks for your PR!

@BrewTestBot BrewTestBot mentioned this pull request Sep 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cakebaker cakebaker cakebaker left review comments

@sylvestre sylvestre sylvestre left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Touch missing '-f' flag

4 participants

@VenetiaFurtado @sylvestre @satmandu @cakebaker