unexpand: add -f short alias for --first-only #8229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
could you please add a test to make sure we don't regress ? and document this diff |
Contributor
Author
|
Ok, will document the diff. |
GTimothy
force-pushed
the
busybox-first-only-alias
branch
from
ad42181 to
ce0c2af
Compare
Contributor
Author
|
the gnu test |
Contributor
|
yes, we want tests in the rust testsuite as they are easy to run and run quickly |
sylvestre
reviewed
Jun 19, 2025
add the `--first-only` alias `-f` expected by busybox. document the change. Co-authored-by: Sylvestre Ledru <[email protected]>
add two tests for the `-f` alias
GTimothy
force-pushed
the
busybox-first-only-alias
branch
from
6fe2011 to
2fa89ca
Compare
Contributor
Author
|
@sylvestre Currently it is split in two commits. Should I merge them into one (if the tests are ok) ? |
Contributor
|
don't bother :) |
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
--first-onlyalias-fexpected by busyboxIt reduces test failures for
make UTILS=unexpand busytestfrom 7 to 2.