fix low-count lints in all crates #7716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyurik
changed the title
nyurik
force-pushed
the
clippy-all
branch
7 times, most recently
from
bc5fd3d to
0e600ba
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
nyurik
force-pushed
the
clippy-all
branch
2 times, most recently
from
9a12867 to
de38959
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Running this command showed a list of all lints across all crates:
```shell
cargo clippy --all-targets --workspace --message-format=json --quiet | jq -r '.message.code.code | select(. != null and startswith("clippy::"))' | sort | uniq -c | sort -h -r
```
This resulted in a list that I added to the `[workspace.lints.clippy]` in the root Cargo.toml. Afterwards, I commented out a few simpler lints. Subsequentely, I will go through this list, trying to address items in smaller batches.
|
GNU testsuite comparison: |
sylvestre
reviewed
Apr 14, 2025
| all = { level = "warn", priority = -1 } | ||
| cargo = { level = "warn", priority = -1 } | ||
| pedantic = { level = "warn", priority = -1 } | ||
| cargo_common_metadata = "allow" # 3240 |
Contributor
There was a problem hiding this comment.
why keeping these numbers? They will be outdated tomorrow
Contributor
Author
There was a problem hiding this comment.
@sylvestre I use these numbers to guide which one I fix next - at which point I remove the entire line, not just the comment
sylvestre
reviewed
Apr 14, 2025
| })); | ||
| } | ||
| #[cfg(target_os = "linux")] | ||
| #[cfg(not(target_os = "linux"))] |
Contributor
There was a problem hiding this comment.
it changed the behavior, no ?
Contributor
Author
There was a problem hiding this comment.
@sylvestre correct - I am pretty certain this was a bug in the code. Note that the code block is actually a noop, so it didn't show up in any testing, but this change makes sure that when code is added, it will be correctly compiled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running this command showed a list of all lints across all crates:
This resulted in a list that I added to the
[workspace.lints.clippy]in the root Cargo.toml. Afterwards, I commented out a few simpler lints. Subsequentely, I will go through this list, trying to address items in smaller batches.Notes
write!instead of creating temp stringsdd.rs- the non-linux cfg was incorrectly used. It was still a noop, so non-consequential