uucore: num_parser: Limit precision when computing 2**exp #7712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The number of digits would grow exponentially when large exponents are passed, leading to conversion of numbers like 0x2p1000000 taking forever to compute. We use exponentiation by squaring to keep the precision within reasonable bounds. Fixes uutils#7708.
drinkcat
force-pushed
the
parse_number_large_hex-fix
branch
from
e9b030d to
4a13f4d
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of digits would grow exponentially when large exponents are passed, leading to conversion of numbers like 0x2p1000000 taking forever to compute.
We use exponentiation by squaring to keep the precision within reasonable bounds.
Fixes #7708.