Test workspace CI on macos #7576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
drinkcat
force-pushed
the
ci-macos
branch
2 times, most recently
from
8bdcc78 to
42d6682
Compare
|
GNU testsuite comparison: |
chcon/runcon rely on the selinux crate, that is empty on non-Linux platforms. This doesn't matter for normal builds that use the default features for the platform (explicitly trying to build them will fail though). This is a problem when using `cargo test --workspace` though, as that tries to build all packages, including uu_chcon/uu_runcon. Just prevent compilation of these source files when target_os != linux.
|
GNU testsuite comparison: |
Collaborator
Author
|
Unlike Windows, this is fairly manageable and issues are contained to 2 tools only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ci: Enable workspace tests on MacOS
chcon/runcon: Only build on Linux
chcon/runcon rely on the selinux crate, that is empty on
non-Linux platforms.
This doesn't matter for normal builds that use the default features
for the platform (explicitly trying to build them will fail though).
This is a problem when using
cargo test --workspacethough,as that tries to build all packages, including uu_chcon/uu_runcon.
Just prevent compilation of these source files when target_os != linux.
Cargo.toml: We moved to edition 2024, drop = from fts-sys