Skip to content

github action: do not fail the GNU test if only intermittent #7283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cakebaker merged 1 commit into from
Feb 10, 2025
Merged

github action: do not fail the GNU test if only intermittent #7283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/GnuTests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ jobs:
have_new_failures="true"
else
MSG="Skip an intermittent issue ${LINE} (fails in this run but passes in the 'main' branch)"
echo "::warning ::$MSG"
echo "::notice ::$MSG"
echo $MSG >> ${COMMENT_LOG}
echo ""
fi
Expand All @@ -291,7 +291,7 @@ jobs:
echo $MSG >> ${COMMENT_LOG}
else
MSG="Skipping an intermittent issue ${LINE} (passes in this run but fails in the 'main' branch)"
echo "::warning ::$MSG"
echo "::notice ::$MSG"
echo $MSG >> ${COMMENT_LOG}
echo ""
fi
Expand Down Expand Up @@ -340,7 +340,10 @@ jobs:
# Compare root tests
compare_tests '${{ steps.vars.outputs.path_GNU_tests }}/test-suite-root.log' "${ROOT_REF_LOG_FILE}" "root"

if test -n "${have_new_failures}" ; then exit -1 ; fi
if [ -n "${have_new_failures}" ]; then
echo "::error ::Found new test failures"
exit 1
fi
- name: Upload comparison log (for GnuComment workflow)
if: success() || failure() # run regardless of prior step success/failure
uses: actions/upload-artifact@v4
Expand Down
Loading